Skip to content

feat(FormControl): remove sx #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 11, 2025
Merged

feat(FormControl): remove sx #6951

merged 15 commits into from
Oct 11, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Oct 6, 2025 •
edited
Loading

Reintroduces #6681 without the subcomponent wrappers since they won't play well with slots

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0df4777

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 6, 2025 12:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 6, 2025 12:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 6, 2025 13:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 6, 2025 17:16 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6951 October 6, 2025 18:48 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 6, 2025 18:56 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3933

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 7, 2025 00:06 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 7, 2025
@francinelucca francinelucca marked this pull request as ready for review October 7, 2025 00:37
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 8, 2025 16:05 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 8, 2025 16:37 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 8, 2025 16:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 8, 2025 17:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6951 October 8, 2025 17:30 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 11, 2025
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Oct 11, 2025
@primer-integration
Copy link

🔴 ci completed with status failure.

@francinelucca
Copy link
Member Author

Failure is on main branch, merging https://github.com/github/github-ui/pull/4409

@francinelucca francinelucca merged commit 2703bc9 into main Oct 11, 2025
42 checks passed
@francinelucca francinelucca deleted the feat/remove-sx-from-formcontrol branch October 11, 2025 02:25
@primer primer bot mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees

No one assigned

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@francinelucca @siddharthkp